This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch libstdc++]: Enable use of 'long long' for mingw targets


2013/9/13 Paolo Carlini <paolo.carlini@oracle.com>:
> Hi,
>
>
> On 09/13/2013 08:51 AM, Kai Tietz wrote:
>>
>> Hello,
>>
>> this patch enables the 'long long' use in libstdc++ for Windows native
>> targets.
>>
>> ChangeLog
>>
>> 2013-09-13  Kai Tietz  <ktietz@redhat.com>
>>
>>      * config/os/mingw32/os_defines.h (_GLIBCXX_USE_LONG_LONG):
>>      Enable feature.
>>      * config/os/mingw-w64/os_defines.h (_GLIBCXX_USE_LONG_LONG):
>>      Likewise.
>>
>> Tested for i686-w64-mingw32, and x86_64-w64-mingw32. I will apply
>> soon, if there are no objections.
>
> Not a real objection, but I don't understand why you need this. The
> configure routine is called as:
>
>     GLIBCXX_ENABLE_LONG_LONG([yes])
>
> thus is on by default (of course) and then it doesn't carry out any special
> test, you can really assume _GLIBCXX_USE_LONG_LONG to be defined, unless
> whoever runs configure explicitly wants it undefined.
>
> Paolo.

The check for this is broken for some Windows targets, due printf
doesn't support in all cases the %ll width modifier.
So why probing, if we know it works.

Kai


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]