This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Support assertions and greedy/ungreedy matching in regex


On Thu, Sep 12, 2013 at 11:51:57AM -0400, Tim Shen wrote:
> On Thu, Sep 12, 2013 at 11:37 AM, Paolo Carlini
> <paolo.carlini@oracle.com> wrote:
> > .. please fix the overlong lines, I spotted quite a few.
> 
> Quite a few? I see only one line by casting:
> egrep '^\+.{80}' a.patch
> 
> Even it's not 81.

That is not the right test, because you need to count all tabs (at least
the leading ones, you probably shouldn't have other tabs) as 8 columns
rather than just one.  And there are 11 lines that are over the 80
columns limit then.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]