This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add implicit C linkage for win32-specific entry points


On 09/12/13 12:20, Kai Tietz wrote:
> Hi Jacek,
>
> 2013/9/12 Jacek Caban <cjacek@gmail.com>:
>> Hi,
>>
>> This is a resend after I'm done with assignment paper work.
>>
>>     gcc/c-family/ChangeLog:
>>         c-target.def: New hook
>>
>>     gcc/ChangeLog:
>>         config/config.gcc: Use new winnt-c.c target hooks
>>         config/t-winnt: New file
>>         config/winnt-c.c: New file
>>         doc/tm.texi.in: Document new hook
>>         doc/tm.texi: Regenerated
>>
>>     gcc/cp/Changelog:
>>         decl.c: Use new cxx_implicit_extern_c hook
>>
>>     gcc/testsuite/ChangeLog:
>>         g++.dg/abi/main.C: Added implicit C linkage tests
>>
> I have the following comments about this patch.
>
> For gcc/config/t-winnt:
> +# Copyright (C) 2004, 2008, 2009, 2010, 2011 Free Software Foundation, Inc.
> +#
>
> Please use here only 2013 as copyright year.  It is an new file and
> current year should be mentioned.
>
> For gcc/config/winnt-c.c the same as above.
>
>
> The rest looks to me ok, but a c++ maintainer should take also a look to it.

I attached a fixed version. Thanks for review.

Jacek

Attachment: patch.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]