This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gcc_GAS_FLAGS: Add more gcc_cv_as_flags overrides


Hi!

On Wed, 11 Sep 2013 14:53:58 -0700, "H.J. Lu" <hjl.tools@gmail.com> wrote:
> On Wed, Sep 11, 2013 at 2:23 PM, Thomas Schwinge
> <thomas@codesourcery.com> wrote:
> > --- gcc/acinclude.m4
> > +++ gcc/acinclude.m4
> > @@ -444,8 +444,16 @@ AC_DEFUN([gcc_GAS_FLAGS],
> >  [AC_CACHE_CHECK([assembler flags], gcc_cv_as_flags,
> >  [ case "$target" in
> >    i[[34567]]86-*-linux*)
> > -    dnl Always pass --32 to ia32 Linux assembler.
> > -    gcc_cv_as_flags="--32"
> > +    dnl Override the default, which may be incompatible.
> > +    gcc_cv_as_flags=--32
> > +    ;;
> > +  x86_64-*-linux-gnux32)
> > +    dnl Override the default, which may be incompatible.
> > +    gcc_cv_as_flags=--x32
> 
> I don't think it is necessary.  I configure x32 gcc with
> 
> CC="gcc -mx32" CXX="g++ -mx32" RUNTESTFLAGS=" .../configure
> --with-multilib-list=m32,m64,mx32 --with-abi=mx32
> 
> There is no difference in as/ld features between x32 and x86-64.

Ah, OK, I thought there was because of the --x32 option being available.
However, if the x86_64 change is approved, I'd suggest to add it anyway,
both for documentation purposes (so that nobody wonders why it is not
handled here), and for consistency (because ASM_SPEC is also handling it
separately).

> > +    ;;
> > +  x86_64-*-linux*)
> > +    dnl Override the default, which may be incompatible.
> > +    gcc_cv_as_flags=--64
> >      ;;


GrÃÃe,
 Thomas

Attachment: pgp4W58q46TpR.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]