This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, libvtv] Fix configure/testsuite issues with libvtv


On Wed, Sep 11, 2013 at 12:07 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Sep 11, 2013 at 11:22 AM, Caroline Tice <cmtice@google.com> wrote:
>> This  patch should fix the issues that people were having with the
>> libvtv testsuite being run (and failing) when GCC was not configured
>> with --enable-vtable-verify.  I am still in the process of running
>> some tests, but at this point I am fairly confident that this patch
>> works correctly.  Even though I am the libvtv maintainer, I would
>> appreciate someone else reviewing this patch too, as a sanity check.
>>
>> -- Caroline Tice
>> cmtice@google.com
>>
>> 2013-09-11 Caroline Tice  <cmtice@google.com>
>>
>>         * Makefile.am: Re-instante ENABLE_VTABLE_VERIFY checks, to make
>>         sure testsuite is not run if libstdc++ and libgcc were not built
>>         with vtable verification.
>>         * Makefile.in: Regenerated.
>>         * configure.ac: Re-instatate checks for --enable-vtable-verify flag,
>>         to make sure testsuite is not run if libstdc++ and libgcc were not
>>         built with vtable verification.
>>         * configure: Regenerated.
>
> I tried it.  I noticed 2 issues:
>
> 1. Correct if I am wrong.  libvtv doesn't work correctly if
> --enable-vtable-verify
> isn't used. Why is libvtv built/installed at all when
> --enable-vtable-verify isn't used.


The short answer is "because Benjamin Kosnik thought we should do it
this way".  Benajmin, who helped me write most of the original
configure and Makefile stuff for libvtv, seemed to feel that it was
best to build libvtv whenever the architecture would allow it.  I do
not fully understand his reasoning, so it may be best to let him
answer this one.


> 2. Why does libvtv/configure.ac have
>
>     echo 'MULTISUBDIR =' >> $ac_file
>     ml_norecursion=yes
>     . ${multi_basedir}/config-ml.in
>
> when AM_ENABLE_MULTILIB is used?  I got
>
> make[3]: Entering directory
> `/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libvtv'
> Makefile:844: warning: overriding recipe for target `multi-do'
> Makefile:775: warning: ignoring old recipe for target `multi-do'
> Makefile:892: warning: overriding recipe for target `multi-clean'
> Makefile:823: warning: ignoring old recipe for target `multi-clean'
>

I do not know exactly why it was done this way, but I see that the
configure.ac files for libsanitizer and libstdc++-v3 seem to do it
exactly this way as well.


Are either of these issues actually causing you problems at the moment?

-- Caroline
cmtice@google.com


> --
> H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]