This is the mail archive of the
mailing list for the GCC project.
Re: [patch 2/2] tree-flow.h restructuring
- From: Andrew MacLeod <amacleod at redhat dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Diego Novillo <dnovillo at google dot com>
- Date: Wed, 11 Sep 2013 08:39:24 -0400
- Subject: Re: [patch 2/2] tree-flow.h restructuring
- Authentication-results: sourceware.org; auth=none
- References: <522F728E dot 4090907 at redhat dot com> <CAFiYyc2b-Z+Rr0qDS3ur3cPtgG+cJ0mdyrTQ8iVwfKRqvtJhTQ at mail dot gmail dot com>
On 09/11/2013 04:55 AM, Richard Biener wrote:
I oringinally did try moving that one function to tree-ssa.c, and
discovered the static pointer-set bits... and toyed with seeing what
else would need to be moved, but didn't spend any real effort on it.
I'll put a little more effort into it :-)
On Tue, Sep 10, 2013 at 9:27 PM, Andrew MacLeod <firstname.lastname@example.org> wrote:
This splits out tree-ssaname related things to tree-ssanames.h. This is then
included from tree-ssa.h
This patch is ok as-is.
similar treatment can be given to tree-phinodes.c
I notice a number of the other ssa passes only export a couple of functions,
and thats it.. no structs or anything like that. (like tree-ssa-uninit.c
which exports ssa_undefined_value_p but that cant be easily relocated since
it depends on static objects in the file which are constructed earlier by
Well - usually the reason is a bad design choice. There should have been
a ssa_undefined_value_p predicate without the special
possibly_undefined_names pointer-set handling available in generic code
and tree-ssa-uninit.c wrapping that adding it's own special handling.
Most of the awkwardness here is because the generic uninit warning
machinery resides in tree-ssa.c. Consider moving that (the
early uninit pass and its helpers) to tree-ssa-uninit.c.
Someday it will be more obvious :-) yes, I will keep that in mind,
and you can catch what I miss, like types_compatible_p :-)
Keep in mind the tree (GENERIC) vs. GIMPLE (non-SSA specific) and
SSA (SSA-on-GIMPLE specific) distinction.