This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH v2 0/6] Port symtab/cgraph/varpool nodes to use C++ inheritance; rename types.
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 10 Sep 2013 20:46:10 -0400
- Subject: Re: [PATCH v2 0/6] Port symtab/cgraph/varpool nodes to use C++ inheritance; rename types.
- Authentication-results: sourceware.org; auth=none
- References: <20130820210104 dot GC16244 at atrey dot karlin dot mff dot cuni dot cz> <1378755140-5555-1-git-send-email-dmalcolm at redhat dot com> <20130910125242 dot GB25658 at kam dot mff dot cuni dot cz>
On Tue, 2013-09-10 at 14:52 +0200, Jan Hubicka wrote:
> > Here's version 2 of this patch series.
> > The remaining 4 patches rename some types:
> > "symtab_node_base" becomes "symtab_node" (Honza's preferred name, AIUI).
> > This would clash with the pre-existing "symtab_node", which was a
> > typedef for:
> > union symtab_node_def *
> > before patch 1, and for:
> > symtab_node_base *
> > after it.
> > So we eliminate this typedef, and all uses become simply a
> > "symtab_node *", which is the bulk of the renaming. There is also
> > a "const_symtab_node" typedef, which is eliminated; all uses become
> > simply a "const symtab_node *".
> yes, having symtab_node * and then cgraph_node */varpool_node * that will
> later renamed to something like function_node/variable_node seems fine.
> We can also drop _node and make it symbol that would be more descriptive.
(nods). Note that "symbol" is used as a variable name throughout the
source tree, which would complicate such a renaming, so let's defer that