This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 0/6] Port symtab/cgraph/varpool nodes to use C++ inheritance; rename types.

On Tue, 2013-09-10 at 14:52 +0200, Jan Hubicka wrote:
> > Here's version 2 of this patch series.
> > The remaining 4 patches rename some types:
> > 
> > "symtab_node_base" becomes "symtab_node" (Honza's preferred name, AIUI).
> > 
> > This would clash with the pre-existing "symtab_node", which was a
> > typedef for:
> >   union symtab_node_def *
> > before patch 1, and for:
> >   symtab_node_base *
> > after it.
> > 
> > So we eliminate this typedef, and all uses become simply a
> > "symtab_node *", which is the bulk of the renaming.  There is also
> > a "const_symtab_node" typedef, which is eliminated; all uses become
> > simply a "const symtab_node *".
> yes, having symtab_node * and then cgraph_node */varpool_node * that will
> later renamed to something like function_node/variable_node seems fine.
> We can also drop _node and make it symbol that would be more descriptive.

(nods).   Note that "symbol" is used as a variable name throughout the
source tree, which would complicate such a renaming, so let's defer that
to later.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]