This is the mail archive of the
mailing list for the GCC project.
Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv
- From: Caroline Tice <cmtice at google dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 10 Sep 2013 08:55:35 -0700
- Subject: Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv
- Authentication-results: sourceware.org; auth=none
- References: <20130909184825 dot GA4841 at intel dot com> <CABtf2+RD2x9muzhQoo27WWrO6R0eiJ=mqjon7JOA9ga7V97VEw at mail dot gmail dot com> <20130910101731 dot GU1817 at tucnak dot redhat dot com>
On Tue, Sep 10, 2013 at 3:17 AM, Jakub Jelinek <firstname.lastname@example.org> wrote:
> On Mon, Sep 09, 2013 at 01:56:29PM -0700, Caroline Tice wrote:
>> The patch looks good to me, but somebody else needs to approve it.
> Why? You are listed as libvtv maintainer, the patch is fully contained in
> libvtv, thus you can review it and approve.
There was a bit of communication confusion and I originally
misunderstood things. I thought I was the libvtv maintainer, but so
far i have only been proposed (am being proposed?) to the steering
committee to be the libvtv maintainer. Until the steering committee
officially approves that, I am not actually the maintainer, and I do
not have the authority to approve patches.
> On an unrelated note, what kind of testing was performed on libvtv
> I'm seeing very bad results on both x86_64-linux and i686-linux, like
> === libvtv Summary ===
> # of expected passes 92
> # of unexpected failures 44
> # of unresolved testcases 40
> Many of the errors seem to be related to missing vtv_start_preinit.o
> not being found (why do those actually live in libgcc rather than libvtv?),
> libvtv/Makefile.am has only rules for vtv_start.c etc., but not
Actually I performed a lot of testing of this testsuite, but it was
all on my linux x86_64 system. I consistently get it passing all
=== libvtv tests ===
Schedule of variations:
Running target unix
Using /usr/local/share/dejagnu/baseboards/unix.exp as board
description file for target.
Using /usr/local/share/dejagnu/config/unix.exp as generic interface
file for target.
as tool-and-target-specific interface file.
Running /usr/local/google2/cmtice/gcc-fsf/libvtv/testsuite/libvtv.cc/vtv.exp ...
=== libvtv Summary ===
# of expected passes 176
make: Leaving directory
Based on the errors you are reporting, my guess is that you did not
configure with --enable-vtable-verifiy. The testsuite in libvtv will
not pass without vtable verification enabled. If you DID configure
with --enable-vtable-verify, then please send me the rest of your
configure command so that I can try to reproduce your failures.
> But I also see complains from glibc about corrupted malloc state in some
> tests, tests with such undefined behavior IMHO don't belong into the
> testsuite, unless you can prevent the corruption before it happens.
I have never seen that; if you could forward the complaints/errors to
me I would appreciate it.
-- Caroline Tice