This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Remove unused macro and functions from tree-flow.h and tree-flow-inline.h


>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:

Jakub> On Tue, Sep 10, 2013 at 09:04:41AM -0400, Andrew MacLeod wrote:
>> Really? If it were useful I would have thought they'd be using it now.
>> 
>> In any case, it doesn't belong in tree-flow.h.. . shouldn't these
>> functions and macros be in hashtab.h then?

Jakub> It doesn't belong to hashtab.h, because that is a libiberty API, this
Jakub> style of iterators is GCC specific.

FWIW I've occasionally wished that these iterators were in libiberty.
Currently the only iteration interface for hashtab is callback-based,
which is a pain.  Also it seems to me that the iterators belong in
hashtab so as not to violate the module boundary.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]