This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Caroline Tice <cmtice at google dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 10 Sep 2013 12:17:31 +0200
- Subject: Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv
- Authentication-results: sourceware.org; auth=none
- References: <20130909184825 dot GA4841 at intel dot com> <CABtf2+RD2x9muzhQoo27WWrO6R0eiJ=mqjon7JOA9ga7V97VEw at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Sep 09, 2013 at 01:56:29PM -0700, Caroline Tice wrote:
> The patch looks good to me, but somebody else needs to approve it.
Why? You are listed as libvtv maintainer, the patch is fully contained in
libvtv, thus you can review it and approve.
On an unrelated note, what kind of testing was performed on libvtv
testsuite?
I'm seeing very bad results on both x86_64-linux and i686-linux, like
=== libvtv Summary ===
# of expected passes 92
# of unexpected failures 44
# of unresolved testcases 40
Many of the errors seem to be related to missing vtv_start_preinit.o
not being found (why do those actually live in libgcc rather than libvtv?),
libvtv/Makefile.am has only rules for vtv_start.c etc., but not
vtv_start_preinit.c.
But I also see complains from glibc about corrupted malloc state in some
tests, tests with such undefined behavior IMHO don't belong into the
testsuite, unless you can prevent the corruption before it happens.
Jakub