This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR other/58374: Wrong target check in configure.ac in libvtv


The patch looks good to me, but somebody else needs to approve it.

-- Caroline Tice
cmtice@google.com

On Mon, Sep 9, 2013 at 11:48 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> configure.tgt in libvtv only recognizes canonical targets.  This patch
> moves the VTV_SUPPORTED check after AC_CANONICAL_SYSTEM for targets
> like i686-linux or x86_64-linux.  OK to install?
>
> Thanks.
>
>
> H.J.
> ---
> diff --git a/libvtv/ChangeLog b/libvtv/ChangeLog
> index 20092f4..3c344f9 100644
> --- a/libvtv/ChangeLog
> +++ b/libvtv/ChangeLog
> @@ -1,3 +1,9 @@
> +2013-09-09  H.J. Lu  <hongjiu.lu@intel.com>
> +
> +       PR other/58374
> +       * configure.ac: Move VTV_SUPPORTED check after AC_CANONICAL_SYSTEM.
> +       * configure: Regenerated.
> +
>  2013-09-08  Caroline Tice  <cmtice@google.com>
>
>         * testsuite/event-main.cc:  Move to libvtv.cc subdirectory.
> diff --git a/libvtv/configure b/libvtv/configure
> index bb56cb0..0bd614a 100755
> --- a/libvtv/configure
> +++ b/libvtv/configure
> @@ -2339,22 +2339,6 @@ fi
>  { $as_echo "$as_me:${as_lineno-$LINENO}: result: $version_specific_libs" >&5
>  $as_echo "$version_specific_libs" >&6; }
>
> -# See if supported.
> -unset VTV_SUPPORTED
> -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for host support for vtable verification" >&5
> -$as_echo_n "checking for host support for vtable verification... " >&6; }
> -. ${srcdir}/configure.tgt
> -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $VTV_SUPPORTED" >&5
> -$as_echo "$VTV_SUPPORTED" >&6; }
> -
> -# Decide if it's usable.
> -use_vtable_verify=no
> -if test "x$VTV_SUPPORTED" = "xyes"; then
> -  use_vtable_verify=yes
> -  { $as_echo "$as_me:${as_lineno-$LINENO}: using vtable verification" >&5
> -$as_echo "$as_me: using vtable verification" >&6;}
> -fi
> -
>  # Do not delete or change the following two lines.  For why, see
>  # http://gcc.gnu.org/ml/libstdc++/2003-07/msg00451.html
>  ac_aux_dir=
> @@ -2522,6 +2506,22 @@ esac
>
>
>
> +# See if supported.
> +unset VTV_SUPPORTED
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for host support for vtable verification" >&5
> +$as_echo_n "checking for host support for vtable verification... " >&6; }
> +. ${srcdir}/configure.tgt
> +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $VTV_SUPPORTED" >&5
> +$as_echo "$VTV_SUPPORTED" >&6; }
> +
> +# Decide if it's usable.
> +use_vtable_verify=no
> +if test "x$VTV_SUPPORTED" = "xyes"; then
> +  use_vtable_verify=yes
> +  { $as_echo "$as_me:${as_lineno-$LINENO}: using vtable verification" >&5
> +$as_echo "$as_me: using vtable verification" >&6;}
> +fi
> +
>  am__api_version='1.11'
>
>  # Find a good install program.  We prefer a C program (faster),
> diff --git a/libvtv/configure.ac b/libvtv/configure.ac
> index 6db97dc..e3fb92f 100644
> --- a/libvtv/configure.ac
> +++ b/libvtv/configure.ac
> @@ -20,6 +20,13 @@ AC_ARG_ENABLE(version-specific-runtime-libs,
>  [version_specific_libs=no])
>  AC_MSG_RESULT($version_specific_libs)
>
> +# Do not delete or change the following two lines.  For why, see
> +# http://gcc.gnu.org/ml/libstdc++/2003-07/msg00451.html
> +AC_CANONICAL_SYSTEM
> +target_alias=${target_alias-$host_alias}
> +AC_SUBST(target_alias)
> +GCC_LIBSTDCXX_RAW_CXX_FLAGS
> +
>  # See if supported.
>  unset VTV_SUPPORTED
>  AC_MSG_CHECKING([for host support for vtable verification])
> @@ -33,13 +40,6 @@ if test "x$VTV_SUPPORTED" = "xyes"; then
>    AC_MSG_NOTICE(using vtable verification)
>  fi
>
> -# Do not delete or change the following two lines.  For why, see
> -# http://gcc.gnu.org/ml/libstdc++/2003-07/msg00451.html
> -AC_CANONICAL_SYSTEM
> -target_alias=${target_alias-$host_alias}
> -AC_SUBST(target_alias)
> -GCC_LIBSTDCXX_RAW_CXX_FLAGS
> -
>  AM_INIT_AUTOMAKE(foreign no-dist)
>  AM_ENABLE_MULTILIB(, ..)
>  AM_MAINTAINER_MODE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]