This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch to gcc/function] PR 58362

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Richard Biener <rguenther at suse dot de>
Cc: Jakub Jelinek <jakub at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
Date: Mon, 09 Sep 2013 11:57:33 +0200
Subject: Re: [Patch to gcc/function] PR 58362
Authentication-results: sourceware.org; auth=none
References: <522CCF1B dot 8080007 at oracle dot com> <alpine dot LNX dot 2 dot 00 dot 1309090945470 dot 3869 at zhemvz dot fhfr dot qr> <522D8BBC dot 608 at oracle dot com> <alpine dot LNX dot 2 dot 00 dot 1309091132340 dot 3869 at zhemvz dot fhfr dot qr> <alpine dot LNX dot 2 dot 00 dot 1309091136460 dot 3869 at zhemvz dot fhfr dot qr> <20130909094311 dot GG1817 at tucnak dot redhat dot com> <alpine dot LNX dot 2 dot 00 dot 1309091144200 dot 3869 at zhemvz dot fhfr dot qr>

Hi,

On 09/09/2013 11:45 AM, Richard Biener wrote:

Well, in this case the patch should IMHO be a no-op.

-      warning (OPT_Wunused_parameter, "unused parameter %q+D", decl);
+      warning_at (DECL_SOURCE_LOCATION (decl), OPT_Wunused_parameter,
+		  "unused parameter %qD", decl);

no?  Unless I misunderstand what %q+D should do.

See my previous email Richard. The situation should be rather clear now.

Paolo.

References:
- [Patch to gcc/function] PR 58362
  - From: Paolo Carlini
- Re: [Patch to gcc/function] PR 58362
  - From: Richard Biener
- Re: [Patch to gcc/function] PR 58362
  - From: Paolo Carlini
- Re: [Patch to gcc/function] PR 58362
  - From: Richard Biener
- Re: [Patch to gcc/function] PR 58362
  - From: Richard Biener
- Re: [Patch to gcc/function] PR 58362
  - From: Jakub Jelinek
- Re: [Patch to gcc/function] PR 58362
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]