This is the mail archive of the
mailing list for the GCC project.
Re: RFC - Next refactoring steps
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Andrew MacLeod <amacleod at redhat dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Mike Stump <mikestump at comcast dot net>, Diego Novillo <dnovillo at google dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 6 Sep 2013 18:51:13 +0200
- Subject: Re: RFC - Next refactoring steps
- Authentication-results: sourceware.org; auth=none
- References: <20130809223645 dot GA22559 at google dot com> <48A1A20B-1DF2-45A5-9CB6-13CDC6A89A4F at comcast dot net> <cf6d07ba-b8bc-43c2-9f84-e7709ed7730e at email dot android dot com> <5214F775 dot 60702 at redhat dot com> <B962A2B6-233D-4B65-B4BF-CE1B20B0154B at comcast dot net> <52161471 dot 6040408 at redhat dot com> <CAD_=9DTQhKGQHn6KgGJg9bQN9_Ft5DaE3fKJr8OuaALhjQSy+g at mail dot gmail dot com> <CAFiYyc3Tc24A5LExuvOKH_poXqYyJ_GUE8-CbxK1cMnY2VPmUQ at mail dot gmail dot com> <52287FD3 dot 4040204 at redhat dot com> <CAFiYyc0yGMVohSBVdpboTMeFw229DW3ZFbg_rUqSSWUvu0zFqg at mail dot gmail dot com> <5228A7A7 dot 9070606 at redhat dot com> <CAFiYyc1YvbVeVUuE0KMwajJqP7f097XZzY6a8+U5A_ipQfmxSQ at mail dot gmail dot com> <2C884ACE-F1BA-4C49-B3B8-7207E1B8FB9B at comcast dot net> <CAFiYyc3aTXHZpsOfmVa+qniYyBSY1gW1AP+1u7U9ioaJpMdj_g at mail dot gmail dot com> <5229F317 dot 9070501 at redhat dot com>
On Fri, Sep 6, 2013 at 5:21 PM, Andrew MacLeod wrote:
>> hackery in some headers will suddenly break (that is, change outcome)
>> if you include for example
>> tm.h before or after it.
> these would be really good to identify and fix, if possible. (surely they
> can be fixed.. :-) if they cant be fixed for whatever reason, we ought to
> protect them with some mechanism.. ie assert that tm.h either has or has not
> been included before hand... whichever way is required. At least then we
> get an error if it changes.
> Do you know of any of the top of your head?
sched-int.h comes to mind as an example I fixed recently (it needs
INSN_SCHEDULING from insn-attr.h.
But these cases are hard to discover. Usually you simply run into them
while trying to re-arrange the #includes of a .c file.