This is the mail archive of the
mailing list for the GCC project.
Re: [patch] Fix another fallout of partial inlining change
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 06 Sep 2013 11:36:43 +0200
- Subject: Re: [patch] Fix another fallout of partial inlining change
- Authentication-results: sourceware.org; auth=none
- References: <35349363 dot tiXNrEcsXg at polaris> <20130906092630 dot GA5140 at kam dot mff dot cuni dot cz>
> Sorry, I missed your mail and it seems that my original mail did not
> hit the mailing list. I am attaching what I wrote back then for a record.
> The patch fixes situation where function is externaly visible and called
> once. In this case it makes sense to partially inline it into the
> one caller. Previous heuristic was wrong assuming that the function is
> static and thus preventing splitting because it makes more sense to inline
> it always.
OK, thanks for the explanation.
> Thinking about it, we ought to prvent splitting always_inline functions:
> those may contain something that relies on inlining. Either you can
> include in your change or I will fix it as a followup.
I'll let you make the change.