This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Make vector::at() assertion message more useful (try #2)


Hi,

On 09/05/2013 01:36 AM, Paul Pluzhnikov wrote:
On Wed, Sep 4, 2013 at 4:26 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:

For sure concat_size would not be Ok, isn't uglified.
I didn't uglify it because it's inside __gnu_cxx namespace.
Does it still need uglification?
Yes.

    snprintf_lite(__s, sizeof(__s),
                  _N("vector::_M_range_check: __n (which is %zu) >= "
                     "this->size() (which is %zu)"), __n, this->size());
That seems worth exploring, I agree.
Should snprintf_lite be in __gnu_cxx namespace, or be global and be called
__snprintf_lite(), or ...?
In any case it needs the __ in front. Like the rest of the library, to protect vs

#define snprintf_lite 1

in user code. Well known issue...
Is the location of the out-of-line code in libstdc++-v3/libsupc++/ ok?
(Would probably be called snprintf_lite.cc or some such.)
I don't think we want to fiddle with libsupc++, for the time being at least. src/c++98 seem ok to me.
Is the version I've assigned to the symbol -- GLIBCXX_3.4.20 -- ok?
Is a release out with 3.4.20? If not, it's fine. I think it's fine.

Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]