This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch, bz #58312] Fix libssp handling of vsnprintf for cross-compilers


Jakub et al -

The attached patch fixes bug 58312, by replacing the runtime check of
vsnprintf with a compile-time check -- which means that it now
performs the same checks for both native and cross compilers, ensuring
consistency instead of the previous behavior of just discarding some
libssp functions when cross-compiling.

I've tested this by reconfiguring (on an x86-linux cross
configuration) and confirming that it behaves as expected -- the
HAVE_USABLE_VSNPRINTF macro is defined in confdefs.h, and the
config.log has verbosity of output similar to the previous version.
(The formerly-explicit output is included as part of the AC_CHECK_FUNC
macro.)

It is possible that this will enable the macro on some native
configurations where vsnprintf was present but is broken.  The effect
is simply that a few additional functions (which rely on vsnprintf)
are compiled into libssp; this seems relatively innocuous.

Jakub, I'm cc'ing you in hopes that you're a reasonably appropriate
person to review this.

Ok for trunk?

Thanks,
- Brooks

--------------------
2013-09-03  Brooks Moses  <bmoses@google.com>

        * configure.ac: Replace runtime vsnprintf check with
          compile-time check.
        * configure: Regenerate.

Attachment: 2013-09-03_libssp-configure.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]