This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Clean up pretty printers [15/n]
- From: Gabriel Dos Reis <gdr at axiomatics dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 25 Aug 2013 13:11:57 -0500
- Subject: Re: Clean up pretty printers [15/n]
- References: <8738py71tx dot fsf at euclid dot axiomatics dot org> <Pine dot LNX dot 4 dot 64 dot 1308251510450 dot 1471 at digraph dot polyomino dot org dot uk> <878uzpg4t9 dot fsf at euclid dot axiomatics dot org> <Pine dot LNX dot 4 dot 64 dot 1308251701580 dot 1471 at digraph dot polyomino dot org dot uk>
"Joseph S. Myers" <joseph@codesourcery.com> writes:
[...]
| > | > @@ -379,15 +375,15 @@
| > | > switch (code)
| > | > {
| > | > case INTEGER_TYPE:
| > | > - pp_string (pp, (TYPE_UNSIGNED (t)
| > | > - ? M_("<unnamed-unsigned:")
| > | > - : M_("<unnamed-signed:")));
| > | > + pp->translate_string (TYPE_UNSIGNED (t)
| > | > + ? "<unnamed-unsigned:"
| > | > + : "<unnamed-signed:");
| > |
| > | may need each case of the conditional expression to be marked for
| > | extraction for translation, or to be separated into two separate calls
| > | using "if" (we've had that issue before with conditional expressions in
| > | diagnostics).
| >
| > Hmm, why would that be needed now, and not before?
| > (not that I am found of the conditional, but only by curiosity.)
|
| Previously, each string was inside a separate call to M_() - the strings
| themselves were the msgid parameters. Now, the msgid parameter is not a
| single string but a more complicated expression and xgettext may not
| handle such expressions properly the way it handles having just a single
| string as parameter.
OK, thanks the explanation.
Do you think the same issue arise with diagnostic_set_info,
diagnostic_append_note?
-- Gaby