This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch 2/2] Localization problem in regex

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Tim Shen <timshen91 at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 23 Aug 2013 16:26:48 +0200
Subject: Re: [Patch 2/2] Localization problem in regex
References: <CAPrifDnYX-GGKycPD1Zcmfuah3i7dXsObQMWKuOGq8iszPETLA at mail dot gmail dot com> <5217398F dot 50202 at oracle dot com> <CAPrifDn_gV92-Mw0n7t3U+QH3EEkCFXJd9Ogpk_PShGJXpJqwg at mail dot gmail dot com>

On 08/23/2013 03:59 PM, Tim Shen wrote:

On Fri, Aug 23, 2013 at 6:29 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:

Thanks a lot indeed. But: "Fix callers" of *what*?!? And from *where*? To be
really honest this kind of ChangeLog entry doesn't make much sense. Please
get used to list the specific functions you are changing. It's important.

I see.

Actually I find a mistake by this review /w\, thanks!

Great. But please but the names of the functions you are changingbetween round brackets. You have tons of examples everywhere.


Paolo.

Follow-Ups:
- Re: [Patch 2/2] Localization problem in regex
  - From: Tim Shen

References:
- [Patch 2/2] Localization problem in regex
  - From: Tim Shen
- Re: [Patch 2/2] Localization problem in regex
  - From: Paolo Carlini
- Re: [Patch 2/2] Localization problem in regex
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]