This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- From: Florian Weimer <fweimer at redhat dot com>
- To: Caroline Tice <cmtice at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Ian Lance Taylor <iant at google dot com>, Eric Christopher <echristo at google dot com>, Benjamin De Kosnik <b dot dekosnik at gmail dot com>, Benjamin Kosnik <bkoz at redhat dot com>
- Date: Tue, 20 Aug 2013 21:43:27 +0200
- Subject: Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- References: <CABtf2+SE75qwSodDpFjCEQ-DVFtY4B4dhVgMopNUA9z3FaCXRQ at mail dot gmail dot com> <520494FD dot 5030207 at redhat dot com> <CABtf2+SzFffNo78Ey9sr=wsrm8-5_3DzYAE6LALkYu06fHeHfQ at mail dot gmail dot com> <5207EE34 dot 6000409 at redhat dot com> <CABtf2+Sqm2PrKoGmug-FGveWze447uoTgzmmtJkWWgOQNHgBWA at mail dot gmail dot com> <5208C3BD dot 3090605 at redhat dot com> <CABtf2+QuhyWcmbQ_U+arO3k+B1EEaR31Xxf7n-jjiQHt6UjUeA at mail dot gmail dot com> <520BA33E dot 9030401 at redhat dot com> <CABtf2+RhFYC8ekzucTGP_ndnU4bPBBZ-NucfuYCGkfK4ESpLjQ at mail dot gmail dot com> <521249DA dot 4080102 at redhat dot com> <CABtf2+QRNiBQwaSao+ujF9s=W3oyCd7ceALVwNA03VRgH4YGqQ at mail dot gmail dot com> <5213B6DC dot 4040608 at redhat dot com> <CABtf2+Tvmf886RhzALy=QmkbfumW0kzb+7BjY146xdmg7bnpsQ at mail dot gmail dot com>
On 08/20/2013 09:15 PM, Caroline Tice wrote:
That fixed it, thanks! Attached is the latest patch (Florian, I will
send you the regenerated Makefile.in and configure separately).
Please review and let me know if this is OK to commit!
As the libvtv reviewer, you don't need permission to commit your
changes. :-)
But I bootstrapped on x86_64-debian-linux-gnu, and can confirm that this
now works as intended; __secure_getenv is picked up.
One minor nit:
Index: libvtv/vtv_utils.cc
===================================================================
--- libvtv/vtv_utils.cc (revision 201802)
+++ libvtv/vtv_utils.cc (working copy)
+ decriptor.
There's a stray space at the end of this line.
--
Florian Weimer / Red Hat Product Security Team
- References:
- [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv
- Re: [PATCH, vtv update] Fix /tmp directory issues in libvtv