This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Regex back-reference support
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 10 Aug 2013 20:12:34 +0200
- Subject: Re: [Patch] Regex back-reference support
- References: <CAPrifD=AyZ7GuSgDr0q0nbKFZ3aYWXUL3ZQcytYKLNfUeDq3dg at mail dot gmail dot com> <5206009E dot 60604 at oracle dot com> <CAPrifDmxg-ah3fn982Q4-6XHwCHi+7oiordMHw-DWC4aT6bQGg at mail dot gmail dot com> <52002c60-4ff4-4b33-b2a3-bcadb13b12e8 at email dot android dot com> <CAPrifDnK5Gq9MBhV0R1EG8tWGNFEOoyg-WyX65njgegg7uoH3Q at mail dot gmail dot com> <520664A9 dot 2020504 at oracle dot com>
On 08/10/2013 06:04 PM, Paolo Carlini wrote:
Also, in the new comment, you refer to a "stack", but in the same
patch you removed a std::stack and added a std::vector as data member,
something seems inconsistent.
I had having a closer look to this: if one looks at the code now,
without knowing that a std::stack was there probably the comment makes
perfect sense, doesn't appear confusing (after all you are just using
push_back and pop_back, and std::vector is fine for that).
Paolo.