This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Whole regex refactoring and current status
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 08 Aug 2013 12:01:31 +0200
- Subject: Re: [Patch] Whole regex refactoring and current status
- References: <CAPrifDkAoudaXf=Rwu7jGiBa8nWf9HUx-TQUNGe5a0krJ7pUug at mail dot gmail dot com>
Tim Shen <timshen91@gmail.com> writes:
> As metioned in this[1] email, I here propose a refactored version of
> regex, and show the status:
This patch broke Solaris bootstrap:
In file included from /usr/include/ctype.h:18:0,
from /var/gcc/regression/trunk/10-gcc-gas/build/i386-pc-solaris2.10/libstdc++-v3/include/cctype:42,
from /vol/gcc/src/hg/trunk/local/libstdc++-v3/include/precompiled/stdc++.h:35:
/var/gcc/regression/trunk/10-gcc-gas/build/i386-pc-solaris2.10/libstdc++-v3/include/bits/regex.h:998:25: error: expected nested-name-specifier before numeric constant
template<typename _B, typename _A, typename _C, typename _R>
^
and several more instances. This happens because <iso/ctype_iso.h> (via
<ctype.h>) has:
#define _B 0x00000040 /* Blank */
#define _C 0x00000020 /* Control character */
This is already documented:
http://gcc.gnu.org/onlinedocs/libstdc++/manual/source_code_style.html#coding_style.bad_identifiers
Please fix.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University