This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran OOP] PR 57966: Using a TBP to specify the shape of a dummy argument


Committed as r201254.

Cheers,
Janus



2013/7/25 Janus Weil <janus@gcc.gnu.org>:
> 2013/7/25 Tobias Burnus <burnus@net-b.de>:
>> Janus Weil wrote:
>>>
>>> 2013/7/25 Tobias Burnus <burnus@net-b.de>:
>>>
>>>> Looks fine to me. (If I tracked the PR correctly, it only solves the
>>>> original problem but not yet the one of comment 5, does it?)
>>>
>>> No, this one should actually fix both. I can also add the variant from
>>> comment 5 to the test case, if you prefer.
>>
>>
>> I think that would be good - maybe in a separate module but in the same
>> file?
>
> Same module should be ok, too, I guess. Also it might be good to check
> for the subroutine case (specific and generic), which should actually
> throw an error message.
>
> That my first patch showed no regressions indicates that such a check
> is missing in the testsuite.
>
> I'll commit the attached version ...
>
> Cheers,
> Janus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]