This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Go patch committed: Update libgo to 1.1.1


On Wed, Jul 24, 2013 at 4:49 AM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> Ian Lance Taylor <iant@google.com> writes:
>
>> On Thu, Jul 18, 2013 at 6:59 AM, Rainer Orth
>> <ro@cebitec.uni-bielefeld.de> wrote:
>>> Ian Lance Taylor <iant@google.com> writes:
>>>
>>>> I have committed a large patch to update libgo to the library that was
>>>> part of the Go 1.1.1 release.  As usual, I'm not including the entire
>>>> patch in this e-mail message, because it is too large.  I'm only
>>>> including the changes to the files that are partially gccgo-specific.
>>>> Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.
>>>> Committed to mainline and 4.8 branch.
>>>
>>> This broke the Solaris build:
>>>
>>> /vol/gcc/src/hg/trunk/local/libgo/go/log/syslog/syslog_libc.go:18:25: error: use of undefined type 'serverConn'
>>>  func unixSyslog() (conn serverConn, err error) {
>>>                          ^
>>> make[6]: *** [log/syslog.lo] Error 1
>>>
>>> Didn't make much progress on this one.
>>
>> The interface I put in a while back for Solaris support got taken out
>> from the master library, and I missed it.  This patch restores it.
>> Committed to mainline and 4.8 branch.  I've also sent a patch to the
>> master library to restore the interface.
>
>
> --- FAIL: TestReadUnixgramWithUnnamedSocket (0.00 seconds)
>         :0: neighbor address is @
> --- FAIL: TestReadUnixgramWithZeroBytesBuffer (0.00 seconds)
>         :0: neighbor address is @
> --- FAIL: TestUnixConnLocalAndRemoteNames (0.01 seconds)
>         :0: got &net.UnixAddr{Name:"@", Net:"unix"}, expected &net.UnixAddr{Name:"", Net:"unix"}
>         unix_test.go:159: Listener.Accept failed: use of closed network connection
> --- FAIL: TestUnixgramConnLocalAndRemoteNames (0.00 seconds)
>         :0: got &net.UnixAddr{Name:"@", Net:"unixgram"}, expected &net.UnixAddr{Name:"", Net:"unixgram"}
> FAIL
> FAIL: net

Fixed with this patch.  Committed to mainline and 4.8 branch.

Ian

Attachment: foo.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]