This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/6] Andes nds32: testsuite modifications for nds32 target.


Hi, Joseph,

Sorry for the late revised patch.
We have completed all of it based on your review comments.

On 7/10/13 8:08 AM, Joseph S. Myers wrote:
On Mon, 8 Jul 2013, Chung-Ju Wu wrote:

	* gcc.dg/ucnid-11.c: Skip for nds32*-*-*.
	* gcc.dg/ucnid-2.c: Skip for nds32*-*-*.
	* gcc.dg/ucnid-3.c: Skip for nds32*-*-*.

Skipping these tests seems dubious - you should fix the assembler bug that
it fails to support extended identifiers instead of skipping the tests.


We have cooperated with toolchain engineers.
These three cases now are able to tested for nds32 target.

I don't see any sign of new architecture-specific testcases.  It's
generally a good idea to have such tests, to verify that built-in
functions and attributes and options work as expected, that the
diagnostics in the back end are given for the invalid input you expect to
give such diagnostics, etc.  (Of course the gcc.target/nds32 testsuite
will grow over time with testcases for bugs in such architecture-specific
functionality that get found and fixed over time.)


Thanks for the comments.  We added several new target-specific testcases
under gcc.target/nds32, including basic main execution and built-in
functions verification.


A revised patch is provided and here is a summary:

  1. The extend identifiers testcases are supposed to be tested.
  2. Add preliminary nds32-specific testcases.


gcc/testsuite/
2013-07-24  Chung-Ju Wu  <jasonwucj@gmail.com>
	    Shiva Chen  <shiva0217@gmail.com>

	* g++.dg/other/PR23205.C: Skip for nds32*-*-*.
	* g++.dg/other/pr23205-2.C: Skip for nds32*-*-*.
	* gcc.dg/20020312-2.c: Add __nds32__ case.
	* gcc.dg/builtin-apply2.c: Skip for nds32*-*-*.
	* gcc.dg/lower-subreg-1.c: Skip for nds32*-*-*.
	* gcc.dg/sibcall-3.c: Expected fail for nds32*-*-*.
	* gcc.dg/sibcall-4.c: Expected fail for nds32*-*-*.
	* gcc.dg/stack-usage-1.c (SIZE): Define case for __nds32__.
	* gcc.dg/torture/pr37868.c: Skip for nds32*-*-*.
	* gcc.dg/torture/stackalign/builtin-apply-2.c: Skip for nds32*-*-*.
	* gcc.dg/tree-ssa/20040204-1.c: Expected fail for nds32*-*-*.
	* gcc.dg/tree-ssa/forwprop-28.c: Skip for nds32*-*-*.
	* gcc.dg/tree-ssa/pr42585.c: Skip for nds32*-*-*.
	* gcc.dg/tree-ssa/sra-12.c: Skip for nds32*-*-*.
	* gcc.target/nds32: New nds32 specific directory and testcases.
	* lib/target-supports.exp (check_profiling_available): Check for
	nds32*-*-elf.


Best regards,
jasonwucj

Attachment: 4-nds32-testsuite.v2.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]