This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Patch, PR 57801] Waste work in resolve_variable()


Hi,

The problem appears in revision 201034 in version 4.9. I attached a
one-line patch that fixes it.  I also reported this problem
at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57801

Bootstrap and regression-tested on x86_64-linux.

In method "resolve_variable()" in gcc/fortran/resolve.c, the loop on
line 4908 should break immediately after "seen" is set to "true".


2013-07-23  Chang  <pchang9@cs.wisc.edu>

        * resolve.c (resolve_variable): Exit loop after setting seen.


Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c	(revision 201034)
+++ gcc/fortran/resolve.c	(working copy)
@@ -4908,7 +4908,10 @@
 	    for (formal = entry->sym->formal; formal; formal = formal->next)
 	      {
 		if (formal->sym && sym->name == formal->sym->name)
-		  seen = true;
+		  {
+		    seen = true;
+		    break;
+		  }
 	      }

 	  /*  If it has not been seen as a dummy, this is an error.  */


-Chang

Attachment: pr57801_patch.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]