This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, PR 57780] Waste work in subst_dup()


On 07/22/2013 07:39 PM, pchang9@cs.wisc.edu wrote:
Hi,

The problem appears in revision 201034 in version 4.9.  I attached a
one-line patch that fixes it.  I also reported this problem
at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57780

Bootstrap and regression-tested on x86_64-linux.

In method "subst_dup()" in gensupport.c, the loop on line 2181
should not be executed when "code" equals to "MATCH_DUP" or "MATCH_OP_DUP".


2013-07-22  Chang  <pchang9@cs.wisc.edu>

         * gensupport.c (subst_dup): Avoid loop if code is not
         MATCH_DUP nor MATCH_OP_DUP.
Thanks.  Installed.

We're probably getting to a point where the sum of all these fixes is going to require a copyright assignment. If you could start that process with the FSF it would be greatly appreciated.

http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.future

You may also need an employer disclaimer. assign@gnu.org can help you with ensuring you get the right paperwork.


It also seems to me you should get an account on gcc.gnu.org so that you can commit approved changes, close PRs, etc.

Here's the form.  List me as the sponsor/approver:


http://sourceware.org/cgi-bin/pdw/ps_form.cgi


You might also want to review:


http://gcc.gnu.org/svnwrite.html


Thanks again,

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]