This is the mail archive of the
mailing list for the GCC project.
Re: [Patch, PR 57780] Waste work in subst_dup()
- From: Jeff Law <law at redhat dot com>
- To: pchang9 at cs dot wisc dot edu
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 23 Jul 2013 10:19:44 -0600
- Subject: Re: [Patch, PR 57780] Waste work in subst_dup()
- References: <654e83a55326637f306f9d4eacf8b31f dot squirrel at webmail dot cs dot wisc dot edu>
On 07/22/2013 07:39 PM, firstname.lastname@example.org wrote:
The problem appears in revision 201034 in version 4.9. I attached a
one-line patch that fixes it. I also reported this problem
Bootstrap and regression-tested on x86_64-linux.
In method "subst_dup()" in gensupport.c, the loop on line 2181
should not be executed when "code" equals to "MATCH_DUP" or "MATCH_OP_DUP".
2013-07-22 Chang <email@example.com>
* gensupport.c (subst_dup): Avoid loop if code is not
MATCH_DUP nor MATCH_OP_DUP.
We're probably getting to a point where the sum of all these fixes is
going to require a copyright assignment. If you could start that
process with the FSF it would be greatly appreciated.
You may also need an employer disclaimer. firstname.lastname@example.org can help you
with ensuring you get the right paperwork.
It also seems to me you should get an account on gcc.gnu.org so that you
can commit approved changes, close PRs, etc.
Here's the form. List me as the sponsor/approver:
You might also want to review: