This is the mail archive of the
mailing list for the GCC project.
Re: [Patch] Reimplment regex matcher using DFS
- From: Tim Shen <timshen91 at gmail dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 23 Jul 2013 22:13:06 +0800
- Subject: Re: [Patch] Reimplment regex matcher using DFS
- References: <CAPrifDnky=cuvwL0HHCKD5zOkLj5EqFbBm9-HXSyEXYjNUKzMg at mail dot gmail dot com> <51EE882F dot 2060106 at oracle dot com>
On Tue, Jul 23, 2013 at 9:42 PM, Paolo Carlini <email@example.com> wrote:
> This doesn't make much sense to me: if the functions are inside a *.tcc file
> why are marked inline? First blush seem indeed good candidates for inline,
> but then should be in the *.h
My view is like this :
When I put something into the class definition, I expected it doesn't
frequently changing. It's part of the interfaces.
When I find some small function body, I inline it.
In the future the function _M_dfs_match() and
_M_dfs_search_from_first() may change. So I decide to pull them out of
the class definition.
Is this naive or not?