This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libbacktrace: walk the elf_syminfo_data chain in elf_syminfo


On Mon, Jul 22, 2013 at 6:26 AM, Alexander Monakov <amonakov@ispras.ru> wrote:
>
> this fixes a bug (found by inspection) that would prevent elf_syminfo from
> looking up symbols defined in modules other than the executable.
>
> Bootstrapped and regtested together with the next patch on x86_64-linux
> (excluding Java, including Go), OK for trunk?
>
> libbacktrace/Changelog:
> 2013-07-22  Alexander Monakov  <amonakov@ispras.ru>
>
>         * elf.c (elf_syminfo): Loop over the elf_syminfo_data chain.

Thanks for noticing the problem.  This patch isn't enough by itself.
The code has to protect itself against the list changing in
mid-stream.  See dwarf_fileline in dwarf.c.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]