This is the mail archive of the
mailing list for the GCC project.
Re: [Patch] regex_iterator and regex_token_iterator implementation
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 22 Jul 2013 07:29:24 +0200
- Subject: Re: [Patch] regex_iterator and regex_token_iterator implementation
- References: <CAPrifDm07qvEoJEC9BBkRa1yuCrM9vXRoDPTXfJEjfVmj=XKNQ at mail dot gmail dot com> <51EC86EE dot 20004 at oracle dot com> <CAPrifDk8Ur4m3P+Jr-sb231LvWzBPoWFA83hNMRsM5zgP9J0eA at mail dot gmail dot com>
>Should I change them all to "_M_" or "__" format, and why?
Definitely. For the usual reason that if somebody in user code has a macro with the same name before including the header the code is busted. Of course _M_ or _S_ (vs _uppercase) is our specific convention for data members and statistics, but anyway *all* the names of implementation details must be uglified in a conforming implementation, no exceptions.