This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] regex_iterator and regex_token_iterator implementation
- From: Tim Shen <timshen91 at gmail dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 22 Jul 2013 13:13:04 +0800
- Subject: Re: [Patch] regex_iterator and regex_token_iterator implementation
- References: <CAPrifDm07qvEoJEC9BBkRa1yuCrM9vXRoDPTXfJEjfVmj=XKNQ at mail dot gmail dot com> <51EC86EE dot 20004 at oracle dot com>
On Mon, Jul 22, 2013 at 9:12 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Also you are wrongly "un-uglyfying" many names, eg:
>
> - position_iterator __position;
> - const value_type* __result;
> - value_type __suffix;
> - std::size_t __n;
> - std::vector<int> __subs;
>
>
> Remember all the names must begin by double underscore or single underscore,
> etc.
Actually, in code before this patch, private members in class
regex_iterator are indeed start without double or single underscore.
It's because the standard (28.12, n3376) specifies them, though they
are private. IMHO, they are part of standard, so I use names in it.
Should I change them all to "_M_" or "__" format, and why?
Thanks!
--
Tim Shen