This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/*] Fix common typos.
- From: Mike Stump <mikestump at comcast dot net>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 21 Jul 2013 09:35:21 -0700
- Subject: Re: [PATCH 1/*] Fix common typos.
- References: <20130721143204 dot GA27788 at domone>
On Jul 21, 2013, at 7:32 AM, OndÅej BÃlka <neleai@seznam.cz> wrote:
> This is series of typo fixing patches. They are generated with stylepp
> https://github.com/neleai/stylepp
> which makes patch generation very effective.
I've checked in most changes to Objective-C things and test suite things after reviewing all those changes. I agreed with most of the work, except ok -> OK. We don't need to scream in the source, and ok I feel is a fine english word, despite what an expert might think (they would burn us (me) at the grammar stake. They merely trail us in language adoption. :-)
One part I will throw out here, in gcc/testsuite/gcc.target/sh/pr54760-4.c:
- and its use when a function call is inbetween, when GBR is a call used
+ and its use when a function call is between, when GBR is a call used
I think this should be:
- and its use when a function call is inbetween, when GBR is a call used
+ and its use when a function call is in-between, when GBR is a call used
If someone wants to try and counter this, please, I'd favor an expert that can clarify why it would be preferable.