This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] MIPS: MIPS32r2 FP MADD instruction set support

On Tue, 16 Jul 2013, Richard Sandiford wrote:

> >  I only checked executables, these tests do not produce any.  I didn't 
> > think of checking tests that do not produce executables, because they do 
> > not check run-time validity of code produced.  These three tests you've 
> > referred to all pass with or without the change, but they are tangential 
> > to it because they all force -mips4.
> OK, as long as those tests pass then the patch is OK, thanks.  They aren't
> tangential for a -march=vr5400 run though.  The tests force isa=4 rather
> than -mips4, and since the VR5432 is a MIPS IV processor, the tests will
> be run with that -march value.  E.g.
> make check-gcc RUNTESTFLAGS="--target_board unix/-march=vr5400 mips.exp=nmadd*"
> fails for me but:
> make check-gcc RUNTESTFLAGS="--target_board unix/-march=vr5400/-mmad mips.exp=nmadd*"
> passes.

 Thanks for correcting me on how isa=4 works in these tests.  Doesn't that 
mean they don't really provide correct coverage then?  I mean they should 
really pass on whetever targets support these instructions and shouldn't 
fail on targets that do not, either by being skipped or better yet by 
verifying that these instructions are not accidentally produced, shouldn't 

 I have applied this change now, thanks for your review.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]