This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Replace dynamic arrays with vec_tree in Array Notation for C
- From: Richard Henderson <rth at redhat dot com>
- To: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Aldy Hernandez (aldyh at redhat dot com)" <aldyh at redhat dot com>
- Date: Tue, 25 Jun 2013 07:33:38 -0700
- Subject: Re: [PATCH] Replace dynamic arrays with vec_tree in Array Notation for C
- References: <BF230D13CA30DD48930C31D4099330003A43A852 at FMSMSX101 dot amr dot corp dot intel dot com>
On 06/21/2013 05:50 PM, Iyer, Balaji V wrote:
> Hello Richard et al.,
> As I mentioned in my previous email, I have changed all the dynamic array usage in the Array notation for C with vec_trees. I have also made them share the structures from Array Notation for C++.
> In addition, I have replaced the cp_length_mismatch_in_expr_p from the C++ array notation with one in array-notation-common since the parameters will now match.
>
> Is this OK for trunk? It is passing all the array notation tests in x86 and x86_64. It is also passing/failing all other tests as it is supposed to.
>
> Here are the ChangeLog Entries:
>
> gcc/c-family/ChangeLog
> 2013-06-21 Balaji V. Iyer <balaji.v.iyer@intel.com>
>
> * array-notation-common.c (length_mismatch_in_expr): Changed the
> parameter type's from a dynamic array to a vec_tree. Also removed
> the size parameters.
> * c-common.h (length_mismatch_in_expr_p): Fixed prototype's as per
> the change above.
>
> gcc/cp/ChangeLog
> 2013-06-21 Balaji V. Iyer <balaji.v.iyer@intel.com>
>
> * cp-array-notation.c (cp_length_mismatch_in_expr_p): Remove.
> (expand_an_in_modify_expr): Changed a function call from the above
> removed function to length_mismatch_in_expr_p.
>
> gcc/c/ChangeLog
> 2013-06-21 Balaji V. Iyer <balaji.v.iyer@intel.com>
>
> * c-array-notation.c (make_triplet_val_inv): New function.
> (create_cmp_incr): Likewise.
> (create_array_refs): Likewise.
> (fix_builtin_array_notation_fn): Replaced all mallocs with tree vec.
> Also modularized common parts between functions and called the function.
> (build_array_notation_expr): Likewise.
> (fix_conditional_array_notations_1): Likewise.
> (fix_array_notation_expr): Likewise.
> (fix_array_notation_call_expr): Likewise.
>
>
> Thanks,
>
> Balaji V. Iyer.
>
Ok.
r~