This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer
- From: Andrew Haley <aph at redhat dot com>
- To: veillard at redhat dot com
- Cc: Dodji Seketeli <dodji at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Tom Tromey <tromey at redhat dot com>
- Date: Fri, 21 Jun 2013 13:03:16 +0100
- Subject: Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer
- References: <m3txwdvxyj dot fsf at redhat dot com> <51C4355F dot 9070904 at redhat dot com> <20130621111910 dot GM7809 at redhat dot com>
On 06/21/2013 12:19 PM, Daniel Veillard wrote:
> On Fri, Jun 21, 2013 at 12:13:35PM +0100, Andrew Haley wrote:
>> On 08/08/2012 11:08 PM, Dodji Seketeli wrote:
>>> OK to commit?
>>
>> Looks good, but what sets LIBXML2_NEW_BUFFER ?
>
> I lack context but I think I can answer that one :)
>
> LIBXML2_NEW_BUFFER is a libxml2 public macro from <libxml/tree.h>
>
> /*
> * LIBXML2_NEW_BUFFER:
> *
> * Macro used to express that the API use the new buffers for
> * xmlParserInputBuffer and xmlOutputBuffer. The change was
> * introduced in 2.9.0.
> */
>
> http://xmlsoft.org/html/libxml-tree.html#LIBXML2_NEW_BUFFER
Sure, but there's no point adding it to libgcj if it's not set by
anything. It needs an autoconf macro or somesuch.
Andrew.