This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch to fix PR57604
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: Vladimir Makarov <vmakarov at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Fri, 21 Jun 2013 13:00:05 +0200
- Subject: Re: patch to fix PR57604
- References: <51C2462F dot 9040704 at redhat dot com>
On 20/06/13 02:00, Vladimir Makarov wrote:
> I hope the following patch fixes
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57604
>
> Although I have no specific hardware to check this.
>
> The patch also adds a comment about one recent change as it was done in
> the same function.
>
> The patch was successfully bootstrapped and tested on x86/x86-64 and
> s390x (including building java).
With your patch I can successfully bootstrap GCC on s390x with ada and java enabled. Thanks!
However, the ESA mode (31bit) bootstrap seems to have some issues.
With 31bit addressing we cannot make the load address instruction available like a normal add in the
backend since GCC then would try to use it for non-address calculations. This would be wrong since
the highest bit would be ignored then.
The addptr optab proposed by Richard looks like a good solution to me. It could perhaps default to
a normal add for targets where it does not make a difference.
Bye,
-Andreas-