This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Fix misoptimization of LTO firefox
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: gcc-patches at gcc dot gnu dot org
- Date: Thu, 20 Jun 2013 16:24:15 +0200
- Subject: Fix misoptimization of LTO firefox
Index: ChangeLog
===================================================================
--- ChangeLog (revision 200246)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2013-06-20 Jan Hubicka <jh@suse.cz>
+
+ * lto-cgraph.c (input_symtab): Do not set cgraph state.
+
2013-06-20 Joern Rennecke <joern.rennecke@embecosm.com>
PR rtl-optimization/57425
Index: lto/ChangeLog
===================================================================
--- lto/ChangeLog (revision 200246)
+++ lto/ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2013-06-20 Jan Hubicka <jh@suse.cz>
+
+ * lto.c (read_cgraph_and_symbols): Set cgraph state.
+
2013-06-19 Jan Hubicka <jh@suse.cz>
* lto-partition.c (add_references_to_partition): Use
Index: lto/lto.c
===================================================================
--- lto/lto.c (revision 200246)
+++ lto/lto.c (working copy)
@@ -3362,7 +3362,6 @@ read_cgraph_and_symbols (unsigned nfiles
{
unsigned int i, last_file_ix;
FILE *resolution;
- struct cgraph_node *node;
int count = 0;
struct lto_file_decl_data **decl_data;
void **res;
@@ -3544,14 +3543,7 @@ read_cgraph_and_symbols (unsigned nfiles
}
lto_symtab_merge_symbols ();
ggc_collect ();
-
- /* FIXME: ipa_transforms_to_apply holds list of passes that have optimization
- summaries computed and needs to apply changes. At the moment WHOPR only
- supports inlining, so we can push it here by hand. In future we need to stream
- this field into ltrans compilation. */
- if (flag_ltrans)
- FOR_EACH_DEFINED_FUNCTION (node)
- node->ipa_transforms_to_apply.safe_push ((ipa_opt_pass)&pass_ipa_inline);
+ cgraph_state = CGRAPH_STATE_IPA_SSA;
timevar_pop (TV_IPA_LTO_CGRAPH_MERGE);
Index: lto-cgraph.c
===================================================================
--- lto-cgraph.c (revision 200246)
+++ lto-cgraph.c (working copy)
@@ -1451,8 +1451,6 @@ input_symtab (void)
unsigned int j = 0;
struct cgraph_node *node;
- cgraph_state = CGRAPH_STATE_IPA_SSA;
-
while ((file_data = file_data_vec[j++]))
{
const char *data;