This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Fix rtl-optimization/57425
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Joern Rennecke <joern dot rennecke at embecosm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Michael Matz <matz at suse dot de>
- Date: Sun, 16 Jun 2013 12:34:33 +0200
- Subject: Re: RFA: Fix rtl-optimization/57425
- References: <20130615190823 dot wzbakvee68w0kcwo-nzlynne at webmail dot spamcop dot net>
> Bootstrapped/regtested on i686-pc-linux-gnu.
For the record, and as you diagnosed, the change proposed in
http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00367.html
means that we must now be very careful with memory dependency checking in the
various RTL optimization passes. Another example is PR rtl-opt/57569.
The patch is OK on principle but I think that we should use the same interface
for write_dependence_p as for true_dependence_1, i.e. add a mem_mode parameter
instead of a mem_size and add both mem_addr and mem_canonicalized (and since
it doesn't seem that we need x_addr for now, let's set it aside). Btw I agree
that the interface is probably not optimal, but it has been there for a while.
Could you also check that your patch also fixes PR opt/57569 and, if so, add
the reference to the ChangeLog as well as the testcase?
Thanks for working on this.
--
Eric Botcazou