Re: [gomp4/cilk-in-gomp/cilkplus] C++ parsing for Cilk plus <#pragma simd>

[Aldy Hernandez <aldyh at redhat dot com>]

On 05/21/13 10:46, Iyer, Balaji V wrote:
> Hello Aldy et al., Attached, please find a patch on top of gomp4
> branch that implements Cilk's <#pragma simd> for C++. This is done in
> the same fashion as Aldy did in:
> http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00678.html (It creates
> OMP_SIMD trees and let omp-low do the rest).
>
> This patch should be applied on Aldy's branch aldyh/cilk-in-gomp. I
> have also included testsuite code that will catch several errors.

Hi Balaji.

As promised, I have taken over your C++ FE changes and fixed everything 
I pointed out in my review.

I replaced the tests you provided in your patch with my more 
comprehensive ones, after moving mine to the c-c++-common 
infrastructure.  I moved all the C specific tests to 
testsuite/gcc.dg/cilk-plus/ and all the C++ specific tests to 
testsuite/g++.dg/cilk-plus.

I changed some of the C++ FE errors to match the C front-end, and when 
not possible, have adapted the tests to match either the C or the C++ 
error messages.  When the dust settles, I will see if your tests stress 
any cases that mine didn't and incorporate them if necessary.

I cleaned up a lot of stuff, fixed buglets and ICEs that I found while 
running the tests.  However, there are still a handful of failures that 
need to be fixed.

For now I am testing with:

	make check RUNTESTFLAGS="cilk-plus.exp"

which yields the following on x86-64 Linux:

                === gcc Summary ===

# of expected passes            65

                === g++ Summary ===

# of expected passes            70
# of unexpected failures        60

The distinct failures are:

    c-c++-common/cilk-plus/PS/body.c
    c-c++-common/cilk-plus/PS/for1.c
    c-c++-common/cilk-plus/PS/for2.c
    c-c++-common/cilk-plus/PS/for3.c

Attached is the patch I am committing to the branch.  I will start 
looking at the remaining failures next, unless you get bored and want to 
look at them as well :).

Thanks again for your patch.

Attachment: curr
Description: Text document