This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, x86] Use vector moves in memmove expanding
- From: Michael Zolotukhin <michael dot v dot zolotukhin at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, Uros Bizjak <ubizjak at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 5 Jun 2013 18:10:34 +0400
- Subject: Re: [PATCH, x86] Use vector moves in memmove expanding
- References: <CANtU07_xUQHqFVhc=xXcXC1T0c37FhW+F9O8BgHtnoq2LNsEYw at mail dot gmail dot com> <20130417142100 dot GA10525 at kam dot mff dot cuni dot cz> <20130417151245 dot GB10525 at kam dot mff dot cuni dot cz> <CANtU07_TrNXUfTedRR-VEqv7PM91Nme2F5E=s-1TLFrznZz0CA at mail dot gmail dot com> <CANtU07_i4G6SQMf_B_kwptUgrhueCxYyu3FEy=XwV28p2Bgw-A at mail dot gmail dot com> <CANtU078+7ZDTqntod8t+4KCGyHH15WW9SQUqQa82N_WRYnxHMw at mail dot gmail dot com> <CAMe9rOqFkoxz0dBguGkFJSifvrE9HkNr_Ff75NSbgBO+mLZOdw at mail dot gmail dot com> <CANtU07-X-RBFoimDt33=GoxWh5jsCBQ8OzwzHAruDELTq0hHdQ at mail dot gmail dot com> <CAMe9rOrRaZANTPLZQxv8j-V5Ozy75M4d80oCC-rZRT0xQ4a=Rw at mail dot gmail dot com>
I'll prepare some tests shortly,
What about the rest questions?
Thanks, Michael
On 15 May 2013 19:45, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, May 15, 2013 at 5:47 AM, Michael Zolotukhin
> <michael.v.zolotukhin@gmail.com> wrote:
>> Hi HJ,
>>> You use Pmode as the largest integer mode. Is word_mode better
>>> than Pmode since word_mode is DI and Pmode may be SI for x32.
>> I updated the patch to use word_mode instead of Pmode. Bootstrap,
>> make check and Specs2000 are ok.
>>
>> Thanks, Michael
>>
>> On 14 May 2013 19:55, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Tue, May 14, 2013 at 7:34 AM, Michael Zolotukhin
>>> <michael.v.zolotukhin@gmail.com> wrote:
>>>> Hi,
>>>> I attached an updated version of the patch. Looks like the 64-bit issue is
>>>> resolved in it (now a vector mode is explicitly chosen instead of TI- or
>>>> another integer mode). Also, some of remarks are fixed in it - some
>>>> others are still not changed, because I don't know what to do with them right
>>>> now (see my questions in the previous letter).
>>>>
>>>> Could you take a look at the patch?
>>>>
>>>> I checked it on i386/x86_64 bootstrap and make check, and on Specs2000/2006
>>>> (I checked only stability).
>>>>
>>>
>>> You use Pmode as the largest integer mode. Is word_mode better
>>> than Pmode since word_mode is DI and Pmode may be SI for x32.
>>>
>>>
>
> You should include tests to verify that it works as
> expected.
>
>
> --
> H.J.
--
---
Best regards,
Michael V. Zolotukhin,
Software Engineer
Intel Corporation.