This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Fortran, committed] Fix bugs in the dg-* directives in the test suite (was: testsuite oddities)
- From: Mike Stump <mrs at mrs dot kithrup dot com>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: Manfred Schwarb <manfred99 at gmx dot ch>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 4 Jun 2013 09:58:15 -0700
- Subject: Re: [Fortran, committed] Fix bugs in the dg-* directives in the test suite (was: testsuite oddities)
- References: <51AD115A dot 5080202 at gmx dot ch> <51AD992E dot 502 at net-b dot de>
On Jun 4, 2013, at 12:37 AM, Tobias Burnus <burnus@net-b.de> wrote:
> I think some of the test cases might to it on purpose: "dg-do run" causes the test case to run only once while "dg-do run" runs multiple times with different options. If the testcase is supposed to test the run-time library, calling it multiple times is pointless. Admittedly, using two spaces is an ugly hack,
:-o, The things we never knew. Anyway, use of hacks like this, should result in the hack being documented. At least then we can find them with find-grep in emacs, and know about it. I'm not in favor of using hacks like this, I don't endorse it. If someone wants to approve such a patch in their part of the test suite, that's fine with me.
> but creating a "dg-do run-single" is difficult.
Well, my first question is, why can't test cases that run in a context that means, run multiple times, be moved from that context, to a context that means, run once? Seems straight forward. In the C test suite, that would be moving from \*torture to \* (other than torture), usually. If fortran doesn't have a run once context, seems reasonable to create one, I'd recommend doing this once there are 20 or more test cases that use the hack.