This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, Fortran] Better error messages for type/rank checks

From: Janus Weil <janus at gcc dot gnu dot org>
To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
Cc: Manfred Schwarb <manfred99 at gmx dot ch>, Tobias Burnus <burnus at net-b dot de>, gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 31 May 2013 14:28:39 +0200
Subject: Re: [Patch, Fortran] Better error messages for type/rank checks
References: <CAKwh3qjTfdWCvA4+jRDiz8WmB6GHJtq1OdOecSrdBw3zUTqxnQ at mail dot gmail dot com> <51A7C4BE dot 9060509 at net-b dot de> <CAKwh3qhH+Z_ydyeFGUaHkvwwb3Je-cbbe=5FkwUDzHu1c4aw7w at mail dot gmail dot com> <51A874BC dot 4070901 at gmx dot ch> <CAKwh3qjFVUbM2QXBMRy09T77DDYP31rd+SpXBAHzADQexUAK-w at mail dot gmail dot com> <CAO9iq9F7oW4G+cWeq3hkN_R+E=JBYpSHeRPo=xje1hSgTmFOTA at mail dot gmail dot com>

> Wouldn't it work to use the TIOCGWINSZ ioctl only if isatty() reports
> that we're outputting to a terminal?

Good point. Updated patch attached, which imposes no limit if we're
not outputting to a terminal (as suggested by Mikael).

Ok for trunk, or am I missing anything else? (Testing welcome ...)

Cheers,
Janus

Attachment: terminal_width_v2.diff
Description: Binary data

Follow-Ups:
- Re: [Patch, Fortran] Better error messages for type/rank checks
  - From: Manfred Schwarb
- Re: [Patch, Fortran] Better error messages for type/rank checks
  - From: Mikael Morin

References:
- [Patch, Fortran] Better error messages for type/rank checks
  - From: Janus Weil
- Re: [Patch, Fortran] Better error messages for type/rank checks
  - From: Tobias Burnus
- Re: [Patch, Fortran] Better error messages for type/rank checks
  - From: Janus Weil
- Re: [Patch, Fortran] Better error messages for type/rank checks
  - From: Manfred Schwarb
- Re: [Patch, Fortran] Better error messages for type/rank checks
  - From: Janus Weil
- Re: [Patch, Fortran] Better error messages for type/rank checks
  - From: Janne Blomqvist

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]