This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PING]RE: [patch] cilkplus: Array notation for C patch
- From: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Richard Henderson <rth at redhat dot com>, "'Joseph S. Myers'" <joseph at codesourcery dot com>, 'Aldy Hernandez' <aldyh at redhat dot com>, 'gcc-patches' <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 23 May 2013 21:08:29 +0000
- Subject: RE: [PING]RE: [patch] cilkplus: Array notation for C patch
- References: <BF230D13CA30DD48930C31D409933000333E32EE at FMSMSX101 dot amr dot corp dot intel dot com> <519C3406 dot 5010900 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A426FF6 at FMSMSX101 dot amr dot corp dot intel dot com> <519D0180 dot 5030203 at redhat dot com> <BF230D13CA30DD48930C31D4099330003A427882 at FMSMSX101 dot amr dot corp dot intel dot com> <20130523190349 dot GD1377 at tucnak dot redhat dot com> <BF230D13CA30DD48930C31D4099330003A427967 at FMSMSX101 dot amr dot corp dot intel dot com> <519E815C dot 8020401 at redhat dot com>
> -----Original Message-----
> From: Jeff Law [mailto:law@redhat.com]
> Sent: Thursday, May 23, 2013 4:52 PM
> To: Iyer, Balaji V
> Cc: Jakub Jelinek; Richard Henderson; 'Joseph S. Myers'; 'Aldy Hernandez'; 'gcc-
> patches'
> Subject: Re: [PING]RE: [patch] cilkplus: Array notation for C patch
>
> On 05/23/2013 02:38 PM, Iyer, Balaji V wrote:
> >
> > Hi Jakub & Aldy, There are a couple reasons why I picked this
> > hierarchy. I looked at gcc-c-torture directory and it has compile,
> > execute etc. This is why I had execute, compile and errors directory.
> > Also, we are planning to have some hybrid tests that will add array
> > notation + cilk keywords, array notation + pragma simd, etc. Yes, I
> > can see the deeply buried issue, but I once had long file names
> > (~25-30 characters) that tells what kind of tests (when we first
> > opened the branch) they are and someone in the mailing list complained
> > that the file names were long and suggested that I use directories
> > instead. If it is OK with you both I would like to keep this hierarchy
> c-torture is the oldest of our testing frameworks -- it goes back to separate c-
> torture testing releases from Tege. IIRC those were originally just shell scripts
> which were invoked on every file in the directory. Thus every file in a particular
> directory had to have the same characteristics (ie, it must compile, compile &
> run, not compile).
>
> I'm guessing Aldy & Jakub want this stuff done in the dg-torture framework
> which would flatten out one of the directories.
>
> As someone (rth?) mentioned elsewhere, we have some tests that can and
> should be shared between the C & C++ front-end. Most if not all of
> these seem to fall into that category. I'd separate them into
> common to c/c++ (in the c-c++-common directory), c specific and c++ specific
> which would go into the gcc.dg and g++.dg directories.
>
> I'd squash out the cilk-plus directory. While this is currently an extension, this
> may ultimately end up being part of ISO-C rather than being an extension.
If I put things in c-c++-common, how do I test the code with different flags (I didn't see any .exp file there)? For example, how can I test if it works with "-O2" and then have another test for "-O2 -g" etc.? Do I just use multiple "dg-options" in my code? The way I have it right now, it uses several flags, and tries them in different combinations. I am if this is a trivial question, I am not very familiar with DejaGNU framework and I went through GCC and DejaGNU manual a while back and I couldn't find an answer for this.
Thanks,
Balaji V. Iyer.
>
> Jeff