This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING]RE: [patch] cilkplus: Array notation for C patch


On 05/23/2013 02:38 PM, Iyer, Balaji V wrote:

Hi Jakub & Aldy, There are a couple reasons why I picked this
hierarchy. I looked at gcc-c-torture directory and it has compile,
execute etc. This is why I had execute, compile and errors directory.
Also, we are planning to have some hybrid tests that will add array
notation + cilk keywords, array notation + pragma simd, etc. Yes, I
can see the deeply buried issue, but I once had long file names
(~25-30 characters) that tells what kind of tests (when we first
opened the branch) they are and someone in the mailing list
complained that the file names were long and suggested that I use
directories instead. If it is OK with you both I would like to keep
this hierarchy
c-torture is the oldest of our testing frameworks -- it goes back to separate c-torture testing releases from Tege. IIRC those were originally just shell scripts which were invoked on every file in the directory. Thus every file in a particular directory had to have the same characteristics (ie, it must compile, compile & run, not compile).

I'm guessing Aldy & Jakub want this stuff done in the dg-torture framework which would flatten out one of the directories.

As someone (rth?) mentioned elsewhere, we have some tests that can and should be shared between the C & C++ front-end. Most if not all of these seem to fall into that category. I'd separate them into common to c/c++ (in the c-c++-common directory), c specific and c++ specific which would go into the gcc.dg and g++.dg directories.

I'd squash out the cilk-plus directory. While this is currently an extension, this may ultimately end up being part of ISO-C rather than being an extension.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]