This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Do not allow non-top-level BIT_FIELD_REFs, IMAGPART_EXPRs or REALPART_EXPRs
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Martin Jambor <mjambor at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Biener <rguenther at suse dot de>
- Date: Thu, 23 May 2013 11:20:43 +0200
- Subject: Re: [PATCH] Do not allow non-top-level BIT_FIELD_REFs, IMAGPART_EXPRs or REALPART_EXPRs
- References: <20130522151105 dot GF23266 at virgil dot suse>
> earlier this week I asked on IRC whether we could have non-top-level
> BIT_FIELD_REFs and Richi said that we could. However, when I later
> looked at SRA code, quite apparently it is not designed to handle
> non-top-level BIT_FIELD_REFs, IMAGPART_EXPRs or REALPART_EXPRs. So in
> order to test whether that assumption is OK, I added the following
> into the gimple verifier and ran bootstrap and testsuite of all
> languages including Ada and ObjC++ on x86_64. It survived, which
> makes me wondering whether we do not want it in trunk.
This looks plausible to me, but I think that you ought to verify the real
assumption instead, which is that the type of the 3 nodes is always scalar.
The non-toplevelness of the nodes is merely a consequence of this property.
--
Eric Botcazou