This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.8 PATCH, i386]: Fix PR 57356, SSE2 instructions generated with '-mno-sse2'
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 22 May 2013 10:01:12 +0200
- Subject: Re: [4.8 PATCH, i386]: Fix PR 57356, SSE2 instructions generated with '-mno-sse2'
- References: <CAFULd4a_zWk8CFKKVjaWts3K2=8CDH7zXOfhZHfbL_BosOg7Rw at mail dot gmail dot com> <20130522075519 dot GD1377 at tucnak dot redhat dot com>
On Wed, May 22, 2013 at 9:55 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, May 21, 2013 at 07:03:54PM +0200, Uros Bizjak wrote:
>> This patch avoids movdqu/movdqa when SSE2 is disabled. Although
>> -mno-sse2 is bordering on ABI violation for 64bit targets, the patch
>> is simple enough to fix movti_internal_rex64 pattern.
>
> If the TImode attr variant isn't valid for !SSE2, I'd find it clearer
> to do
> (match_test "!TARGET_SSE2") (const_string "V4SF")
> much earlier in the cond, before TARGET_AVX case that returns TImode
> (sure, when TARGET_AVX is true, then !TARGET_SSE2 is false), and
> not added using ior to an unrelated condition.
Yes, this is a good suggestion, I was trying to be consistent with the
movti_internal pattern.
I will change both in the way you suggested ASAP.
Thanks,
Uros.