This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[C++ Patch] PR 23608


Hi,

this issue was primarily about a bogus warning for line 9 of the original testcase (the line 'ic < 5u;') which it's already fixed in 4.8.

While reassessing it, I noticed that the location for the genuine warning, which should point to the '<' operator, is off two chars to the right: that can be easily fixed by propagating loc from build_new_op_1 to cp_build_binary_op. Note, I have to adjust an existing testcase: I think it was incorrect to refer to the macro for the -Wdouble-promotion warning about the implicit conversion in the binary expression: the issue doesn't happen when the macro is expanded, but later for the '+' in 'cf + 1.0 * ID'.

Tested x86_64-linux.

Thanks!
Paolo.

//////////////////////////

Attachment: CL_23608
Description: Text document

Attachment: patch_23608
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]