This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: GCC does not support *mmintrin.h with function specific opts
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Sriraman Tallam <tmsriram at google dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Diego Novillo <dnovillo at google dot com>, David Li <davidxl at google dot com>
- Date: Sun, 19 May 2013 12:39:52 +0200
- Subject: Re: GCC does not support *mmintrin.h with function specific opts
- References: <CAAs8Hmy34GY0c1PNyvtGW3vtHZ_cVY+PRy0tLuAuvvP8=FaREA at mail dot gmail dot com> <CAAs8HmzO4Mx1W-+RbmhhOH6nNLRQ5TtNeaqpxR-AS0ZR_9vuzw at mail dot gmail dot com> <CAMe9rOomjVGV5rpqRkLqPB530uEPYMcVGU6hAScbjs2eeW-etg at mail dot gmail dot com> <CAFULd4YNGAfhwao+ZKVuHTE1uvqiB04qrdX5FeZxBcVw0Yr1TQ at mail dot gmail dot com> <20130514083913 dot GJ1377 at tucnak dot redhat dot com> <20130514100419 dot GM1377 at tucnak dot redhat dot com> <CAAs8Hmz3mkGchO8p3DZ9G18ASj91mgR69MrhKRL1F7ORCG8a4A at mail dot gmail dot com> <CAAs8HmzWkgmzyh0neX1UH8kydUejpTqUnLBjv25=A56jk3-DWw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 02 dot 1305170045260 dot 3955 at laptop-mg dot saclay dot inria dot fr> <CAAs8HmyqOMr=kiVXisKQ0BMy6-7vBpvsh7vYhwG2RoOcxu3h=w at mail dot gmail dot com> <20130517054931 dot GM1377 at tucnak dot redhat dot com> <CAAs8HmwAVJqNe+e1C17Vnq5PcEvYuaBfw-jhGU1mRLLDMpsSvw at mail dot gmail dot com>
On Sat, May 18, 2013 at 6:00 AM, Sriraman Tallam <tmsriram@google.com> wrote:
>>> > I don't really understand why you made the change to x86intrin.h instead of
>>> > making it inside each *mmintrin.h header. The code would be the same size,
>>> > it would let us include smmintrin.h directly if we wanted to, and
>>> > x86intrin.h would also automatically work.
>>>
>>> Right, I should have done that instead!
>>
>> Yeah, definitely. For the standalone headers, which have currently
>> __<FEATURE>__ guards inside of it, please replace it by the larger snippets
>> involving #pragma, and in the x86intrin.h/immintrin.h headers include those
>> unconditionally, instead of just if __<FEATURE>__ is defined.
>> For the non-standalone headers (newer ones like avxintrin.h), replace
>> the #ifdef __<FEATURE>__ in immintrin.h/x86intrin.h with larger snippets.
>
>
> * I did mostly as suggested except that even for avx and avx2 headers
> I did not see the harm in doing it in the header itself. AVX header
> did not have the "#ifndef _AVXINTRIN_H_INCLUDED" which I added before
> doing this. I have added test cases to show it is doing the right
> thing for avx.
> * I also found that when the caller to these intrinsics do not have
> the right target attribute, an error is raised in -O2 mode but not in
> -O0 mode. I have fixed this with a patch to ipa-inline.c, please see
> if this is alright. Test case intrinsics_5.c checks if an error is
> raised.
> * LZCNT needed to be handled which is done now.
* common/config/i386/i386-common.c: Handle LZCNT.
The above part is OK for mainline and release patches. Please commit
LZCNT part as a separate patch to mainline.
Also, please get middle-end part reviewed and committed before we
proceed with target-dependent part.
Thanks,
Uros.