This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] New switch optimization pass (PR tree-optimization/54742)
- From: Steve Ellcey <sellcey at imgtec dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Jeff Law <law at redhat dot com>, <gcc-patches at gcc dot gnu dot org>, <dnovillo at google dot com>, <amacleod at redhat dot com>, Zdenek Dvorak <ook at ucw dot cz>
- Date: Thu, 16 May 2013 10:10:49 -0700
- Subject: Re: [PATCH] New switch optimization pass (PR tree-optimization/54742)
- References: <1368476190 dot 22602 dot 109 dot camel at ubuntu-sellcey> <51914D02 dot 30908 at redhat dot com> <CAFiYyc3W1sLOPQPy0XX_QfoLTZc6nioxCh8ikLtdfs26x-BG1A at mail dot gmail dot com> <1368566063 dot 16206 dot 9 dot camel at ubuntu-sellcey> <519316D8 dot 70204 at redhat dot com> <CAFiYyc09pt6B7bPxjmjqpp4wTM=f1FDSTGtU+HtZiwpRBZC5pw at mail dot gmail dot com> <1368642493 dot 16206 dot 34 dot camel at ubuntu-sellcey> <5194549D dot 5070500 at redhat dot com> <CAFiYyc1zs1zoZF0nCneW3fK4pUocZK_DrL6ZCu_Gu3=ZDbfybQ at mail dot gmail dot com>
On Thu, 2013-05-16 at 10:58 +0200, Richard Biener wrote:
> >
> > Hmm, not terribly happy with that wording, but that gives you an idea of
> > what I'm after. When would someone set UPDATE_DOMINANCE to true and what
> > are their responsibilities when they do so.
> >
> > Approved with the name change and a better comment for UPDATE_DOMINANCE.
>
> Btw, the function does _not_ handle arbitrary SEME regions - it only handles
> a single exit correctly and assumes no (SSA) data flows across the others.
> So I'd rather not rename it.
>
> Richard.
>
> > Jeff
I went ahead and checked in the change with the comment updates that
Jeff wanted but left the name of the function as is.
Steve Ellcey
sellcey@imgtec.com