On Wed, May 15, 2013 at 12:50 AM, Teresa Johnson wrote:
On Tue, May 14, 2013 at 2:49 PM, Steven Bosscher wrote:
One nit: Can you keep the verify_hot_cold_block_grouping function
separate? rtl_verify_flow_info* is already too big and complex
(somewhere down on my TODO list is splitting it up and improving
cfglayout mode checking, e.g. to make sure there are no barriers/notes
between basic blocks...).
Initially that's what I did, but then it seemed less efficient because
it adds another iteration over the BBs, so I instead merged the check
with one of the existing BB iterations in that routine. Do you still
prefer that I outline it?
I'm not concerned about efficiency of the checker routines. They only
run with checking enabled anyway. These checkers are almost the best
"documentation" of the rules of GCC's intermediate representations
that we have, so it's more important to me to make them easy to
understand, and to make sure these verifiers themselves are complete
and correct.