This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix thinko in SLSR that caused x86 bootstrap failure
- From: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, richard dot guenther at gmail dot com, bergner at vnet dot ibm dot com
- Date: Mon, 06 May 2013 14:29:00 -0500
- Subject: Re: [PATCH] Fix thinko in SLSR that caused x86 bootstrap failure
- References: <1367786717 dot 11638 dot 58 dot camel at gnopaine> <20130506192506 dot GQ28963 at tucnak dot redhat dot com>
On Mon, 2013-05-06 at 21:25 +0200, Jakub Jelinek wrote:
> On Sun, May 05, 2013 at 03:45:17PM -0500, Bill Schmidt wrote:
> > 2013-05-05 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
> >
> > * gimple-ssa-strength-reduction.c (slsr_process_phi): Re-enable.
> > (find_candidates_in_block): Re-enable slsr_process_phi.
> > (create_phi_basis): Fix double counting of candidate adjustment.
>
> This broke gcc.dg/pr33017.c testcase on i?86/x86_64 -m32.
> ./cc1 -O2 -ftree-vectorize -m32 -mno-sse pr33017.c
Jakub, thanks, I'll take a look.
Bill
> difference between r19862{6,7} is:
> --- pr33017.s1 2013-05-06 21:22:03.786745422 +0200
> +++ pr33017.s2 2013-05-06 21:22:16.844673015 +0200
> @@ -32,9 +32,9 @@ foo:
> movb $87, var.1373+2(%eax)
> je .L10
> cmpl $3, %edx
> - movb $87, var.1373+3(%eax)
> + movb $87, var.1373+2(%eax,%eax)
> jne .L11
> - movb $87, var.1373+4(%eax)
> + movb $87, var.1373+2(%eax,%eax,2)
> movl $3, %ebp
> movl $61, 28(%esp)
> .L3:
>
> Jakub
>